From: Colin Walters <walters@verbum.org>
Date: Fri, 6 Nov 2009 22:15:34 +0000 (-0500)
Subject: [overview] Constrain popup panes, dim workspaces when active
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~10673
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=ce90dda76f28448dadf19099020b570fdfc66387;p=gnome-shell.git

[overview] Constrain popup panes, dim workspaces when active

Rather than the popup panes taking up the whole non-panel height,
constrain them to the height of the workspaces, which is also the
"dash content area".

https://bugzilla.gnome.org/show_bug.cgi?id=600734
---

diff --git a/js/ui/overview.js b/js/ui/overview.js
index dad7822fa..e49119275 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -123,8 +123,7 @@ Overview.prototype = {
 
         // Container to hold popup pane chrome.
         this._paneContainer = new Big.Box({ orientation: Big.BoxOrientation.HORIZONTAL,
-                                            spacing: 6
-                                          });
+                                             spacing: 6 });
         // Note here we explicitly don't set the paneContainer to be reactive yet; that's done
         // inside the notify::visible handler on panes.
         this._paneContainer.connect('button-release-event', Lang.bind(this, function(background) {
@@ -197,9 +196,9 @@ Overview.prototype = {
         this._backOver.set_size(global.screen_width, global.screen_height);
 
         this._paneContainer.set_position(this._dash.actor.x + this._dash.actor.width + DEFAULT_PADDING,
-                                         contentY);
+                                         this._workspacesY);
         // Dynamic width
-        this._paneContainer.height = contentHeight;
+        this._paneContainer.height = this._workspacesHeight;
 
         this._transparentBackground.set_position(this._paneContainer.x, this._paneContainer.y);
         this._transparentBackground.set_size(primary.width - this._paneContainer.x,
@@ -228,6 +227,7 @@ Overview.prototype = {
                     this._activeDisplayPane.close();
                     return true;
                 }));
+                this._workspaces.actor.opacity = 64;
             } else if (pane == this._activeDisplayPane) {
                 this._activeDisplayPane = null;
                 if (backgroundEventId != null) {
@@ -236,6 +236,7 @@ Overview.prototype = {
                 }
                 this._transparentBackground.lower_bottom();
                 this._paneContainer.lower_bottom();
+                this._workspaces.actor.opacity = 255;
             }
         }));
     },